Fix some issues with tabbing into virtualized list #13826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes scenario 1 in #11878.
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Dec 5, 2023
maxkatz6
added
the
backport-candidate-11.0.x
maxkatz6
pushed a commit
that referenced
this pull request
Dec 5, 2023
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
As described in #11878, there were some problems with tabbing into a virtualized list:
We previously had logic in place to not recycle the focused element which meant that when the focused element was scrolled out of view, pressing one of the arrow keys would cause the focus to jump back to the correct selection, however that logic didn't work when tabbing into the control.
The solution for this is:
TabOnceActiveElementalways follow the anchor index, so it's always equal to the last focused elementTabOnceActiveElementto decide when to not recycle an element instead of using actual keyboard focus. This means that the focused element isn't recycled even when focus is currently away from the items controlFixed issues
Fixes #11878